Ask to merge AmigaOS4 port of SMTube in your svn

[zzd10h]

Sorry for the delay, I didn't see you reply before.

Adding the player works in the combobox, it crashs as soon that I try to add it alone.

But I understand your wish and I reviewed players.cpp and ytdialog.cpp to avoid duplicate code

http://zzd10h.amiga-ng.org/Qt/SMTube/players.zip

http://zzd10h.amiga-ng.org/Qt/SMTube/ytdialog.zip

Is it better ?

I see that you added zzd10h in the about.cpp, thank you but my name is Guillaume 'zzd10h' Boesel

Bye and thank you

[rvm]

[zzd10h]

Thank you,
I will try this evening or tomorrow evening.

[rvm]

I've just made some changes (r5992). Now the file where you have to add the info about the amiga player is hcplayer.h

[zzd10h]

[rvm]

[zzd10h]

1) You changed something since.
You said me to use DEFINES -= USE_PLAYERS, now I can remove it ?

2) Yes, I don't know why but isrunning() is always true on Amiga...

Are my changes OK to be included ?

Thanks

[rvm]

If QtSingleApplication doesn't work well on Amiga then I think the best is not use it on Amiga. This way we also avoid to patch the QtSingleApplication files. I added the possibility to compile the application without QtSingleApplication in r5994.

I have just commited your patch in svn r5995. I made a few changes.

Please let me know if it works. Maybe I forgot something.

[zzd10h]

Yes, good idea, I will try tomorrow.

And for the Amiga directory containing my external procedure, is it possible to add it, too, in your repository ?

Like that, Amiga version will be compilabe / runnable directly ?

Thank you by advance.

[rvm]

Send me those files, and maybe a text that explains how to compile it on Amiga, so that the Amiga users can know how to do it.