[bug]searchForConsecutiveFiles

[3togo]

function "searchForConsecutiveFiles" cannot cope with the situation when the number of digits of consecutive files is more than 1.
e.g. XXXXs01e16.avi

I suggest to modify the regexp as follow.


[Karmic-HP64../smplayer/src]$ diff helper.cpp.backup helper.cpp
208c208
< QRegExp rx("^.*(\\d+)");
---
> QRegExp rx("^.*\\D(\\d+)");

[3togo]

[rvm]

It's just that I'm not sure if this is a bug.

The option to add consecutive files to the playlist is intended for movies that are split in multiple files (movie_cd1.avi, movie_cd2.avi and so on).

It seems your patch (according to your example) would add all TV episodes found in a directory. I don't say that is bad, but maybe the user should have the possibility to choose if that is what he wants.

[3togo]

Two points I want to add:
1. Whether the reader wants to add consecutive files is already controlled by an option inside "Preference"->"PlayList"

2. Also by using "d+", the existing regex is seemingly attempting to handle a count that is more than a single digit. However, by using ".*" rather than ".*?", the regex failed to do the job because the former is a greedy approach while the latter not.


original regex : "< QRegExp rx("^.*(\\d+)");"

[rvm]

Ok, I tried to use your patch, but I can't see any difference.

I tried with filenames like flashforward_s01e11.avi and flashforward_s01e12.avi. Both files are added to the playlist with the current code.

Could you give an example of filenames that smplayer fails to add to the playlist?

[3togo]

QRegExp rx("^.*(\\d+)")
xxxs01e09yyy.srt ---> (\\d+) match 9
xxxs01e19yyy.srt ---> (\\d+) match 9

QRegExp rx("^.*\\D(\\d+)")
xxxs01e09yyy.srt ---> (\\d+) match 09
xxxs01e19yyy.srt ---> (\\d+) match 19

QRegExp rx("^.*\\D(\\d+)\\D+")
xxxs01e09yyy.srt ---> (\\d+) match 09
xxxs01e19yyy.srt ---> (\\d+) match 19

[rvm]

Applied your patch in r3493.