This forum is deprecated. Please visit https://github.com/smplayer-dev/smplayer/discussions

[BUG]Wrong chapters switching with mkv files.

Problems, bugs, suggestions... anything related to SMPlayer.

[BUG]Wrong chapters switching with mkv files.

Postby dikei » Tue Aug 24, 2010 7:05 pm

When you click Browse -> Chapter -> n, you'll infact jump to chapter n+1. Consequently, there's no way to jump to the first chapter and clicking on the last chapter in the list will end the file.
dikei
 

Re: [BUG]Wrong chapters switching with mkv files.

Postby dikei » Thu Aug 26, 2010 12:20 pm

I find out the problems.

Smplayer detect the the first chapter is 1 for the version of mplayer I'm using (mplayer-git) while in fact the first chapter is 0.
I suggest 2 way to fix this bug
1. Trying to detect ID_CHAPTER_ID=0 from mplayer output to determine the first chapter. Provided that the mkv file has chapters, if ID_CHAPTER_ID=0 appears, then the first chapter is 0, if ID_CHAPTER_ID=0 do not appears then the first chapter is 1.
2. Bump the svn-version for mplayer-git. The current way of checking for mplayer version is quite hacky, it assumes all mplayer-git equal to mplayer-svn 29073, bumping the svn-version for mplayer-git to something larger than 29407 would give the correct result.
FYI, mplayer-git are now merged up to svn r31332. Source: http://repo.or.cz/w/mplayer.git

BTW, 1.0rc3 has already been released and you can update the svn version for 1.0rc3 now (as you said in the FIXME).
dikei
 
Posts: 5
Joined: Thu Aug 26, 2010 10:23 am


Return to General

Who is online

Users browsing this forum: Google [Bot] and 14 guests